refactor(get_iv; get_all_ivs ): make parameter code handling more general for ivs#10
Open
ntdosch wants to merge 1 commit intoaleaf:developfrom
Open
refactor(get_iv; get_all_ivs ): make parameter code handling more general for ivs#10ntdosch wants to merge 1 commit intoaleaf:developfrom
ntdosch wants to merge 1 commit intoaleaf:developfrom
Conversation
…codes and pull parameter code descriptions from nwis
Codecov Report
@@ Coverage Diff @@
## develop #10 +/- ##
===========================================
+ Coverage 78.19% 79.01% +0.82%
===========================================
Files 11 11
Lines 752 810 +58
===========================================
+ Hits 588 640 +52
- Misses 164 170 +6
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #8 -- Some updates to
get_iv()andget_all_ivs()to handle parameter codes in a more general way and added sample_period and agg_method arguments toget_all_ivs(). Added helper functionget_par_description()to extract the parameter description from sitefile_text. Parameter description is then used as the header of the data column in the returned DataFrame. Should also note that this PR doesn't touch the dv functions.Added a few tests to test_nwis.py to make sure changes work properly (
test_get_ivs_gw,test_get_ivs_sw,test_get_all_ivs_sw, andtest_get_all_ivs_gw)